-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GROW-130 Featured Loans #1953
GROW-130 Featured Loans #1953
Conversation
eddieferrer
commented
Jul 31, 2020
- Implemented features loans on the lend by category homepage
49aca92
to
3823af4
Compare
@@ -194,15 +194,15 @@ $card-half-space: rem-calc(14/2); | |||
box-shadow: 0 0.65rem $card-margin $card-half-space rgb(153, 153, 153, 0.1); | |||
|
|||
&__image-wrapper { | |||
height: rem-calc(168); | |||
height: rem-calc(165); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some very minor style tweaks here in this component.
.lend-by-category-homepage { | ||
overflow: hidden; | ||
} | ||
|
||
.featured-loans { | ||
padding: 2rem 0 1rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section and .loan-categories
dont have the same padding as per the design
* Implemented features loans on the lend by category homepage
3823af4
to
ec5856a
Compare
This PR has the basic functionality of the featured loans carousel. Now that we have preFetch working again on homepage subcomponents. We can prefetch the categories setting, then prefetch the category information, and the featured loan for the first category. Issues I'm aware of and will followup on.
|
This could also be handled by requesting 3-4 loans in the initial query and displaying the first one that isn't funded, which should work for most cases. For the rare case where all of the loans from the initial query are funded, a second query could be done at that point to get another 3-4 loans. Handling it on the backend is an option too, but we would have to figure out what to do with the limit and offset parameters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks great 👍
Had some fussy invariant violations while trying to test but I trust it's just my VM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏